Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow up changes for Prism Ruby parser #1145

Merged
merged 4 commits into from
Aug 1, 2024
Merged

Follow up changes for Prism Ruby parser #1145

merged 4 commits into from
Aug 1, 2024

Conversation

st0012
Copy link
Member

@st0012 st0012 commented Jul 31, 2024 •
edited
Loading

  1. When running RDoc with the Prism Ruby parser, there should be a clear message output
  2. We should run tests with RDOC_USE_PRISM_PARSER on CI too
  3. Since the Prism Ruby parser is optional and disabled by default, it doesn't make sense to require prism as dependency just yet

@st0012 st0012 force-pushed the test-prism-parser-on-ci branch from fd464f5 to 65ce940 Compare August 1, 2024 10:40
@st0012 st0012 changed the title Test Prism Ruby parser on CI Follow up changes for Prism Ruby parser Aug 1, 2024
@st0012 st0012 requested review from hsbt and colby-swandale August 1, 2024 10:44
hsbt
hsbt approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@hsbt hsbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for my consideration🙏

@st0012
Copy link
Member Author

st0012 commented Aug 1, 2024

@tompng FYI

@st0012 st0012 merged commit 9d36593 into master Aug 1, 2024
51 checks passed
@st0012 st0012 deleted the test-prism-parser-on-ci branch August 1, 2024 10:54
@st0012 st0012 added this to the v6.8.0 milestone Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsbt hsbt hsbt approved these changes

@colby-swandale colby-swandale Awaiting requested review from colby-swandale

Assignees
No one assigned
Labels
None yet
Milestone
v6.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@st0012 @hsbt